Fix armhf segfault in error message handling #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On armhf the return value of an error to get a message gets read as value 255 which qualifies as >0. But going on the message pointer has a value of 0x25000000 and later on segfaults when trying to access that. Fixes pgpool#14 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Collaborator
|
Sorry to inform you not earlier. Your patch has been merged into upstream. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On armhf the return value of an error to get a message gets read as
value 255 which qualifies as >0. But going on the message pointer has
a value of 0x25000000 and later on segfaults when trying to access that.
Fixes #14
Signed-off-by: Christian Ehrhardt christian.ehrhardt@canonical.com