Skip to content

support for constant labels #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k0bl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support for constant labels #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/pgpool2_exporter/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ import (

exp "github.com/pgpool/pgpool2_exporter"
)

var (
constantLabelsList = kingpin.Flag("constantLabels", "A list of label=value separated by comma(,).").Default("").Envar("PG_EXPORTER_CONSTANT_LABELS").String()
)
func main() {
promlogConfig := &promlog.Config{}
flag.AddFlags(kingpin.CommandLine, promlogConfig)
Expand All @@ -37,7 +39,7 @@ func main() {
dsn = "postgresql://" + ui + "@" + uri
}

exporter := exp.NewExporter(dsn, exp.Namespace)
exporter := exp.NewExporter(dsn, exp.Namespace, *constantLabelsList)
defer func() {
exporter.DB.Close()
}()
Expand Down
46 changes: 41 additions & 5 deletions pgpool2_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"math"
"net/url"
"os"
"strings"
"regexp"
"strconv"
"sync"
Expand Down Expand Up @@ -157,6 +158,7 @@ type Exporter struct {
totalScrapes prometheus.Counter
metricMap map[string]MetricMapNamespace
DB *sql.DB
constantLabels prometheus.Labels
}

var (
Expand Down Expand Up @@ -223,7 +225,7 @@ var pgpoolVersionRegex = regexp.MustCompile(`^((\d+)(\.\d+)(\.\d+)?)`)
var version42 = semver.MustParse("4.2.0")
var PgpoolSemver semver.Version

func NewExporter(dsn string, namespace string) *Exporter {
func NewExporter(dsn string, namespace string, constantLabels string) *Exporter {

db, err := getDBConn(dsn)

Expand All @@ -239,26 +241,30 @@ func NewExporter(dsn string, namespace string) *Exporter {
Namespace: namespace,
Name: "up",
Help: "Whether the Pgpool-II server is up (1 for yes, 0 for no).",
ConstLabels: parseConstLabels(constantLabels),
}),

duration: prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: namespace,
Name: "last_scrape_duration_seconds",
Help: "Duration of the last scrape of metrics from Pgpool-II.",
ConstLabels: parseConstLabels(constantLabels),
}),

totalScrapes: prometheus.NewCounter(prometheus.CounterOpts{
Namespace: namespace,
Name: "scrapes_total",
Help: "Total number of times Pgpool-II has been scraped for metrics.",
ConstLabels: parseConstLabels(constantLabels),
}),

error: prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: namespace,
Name: "last_scrape_error",
Help: "Whether the last scrape of metrics from Pgpool-II resulted in an error (1 for error, 0 for success).",
ConstLabels: parseConstLabels(constantLabels),
}),
metricMap: makeDescMap(metricMaps, namespace),
metricMap: makeDescMap(metricMaps, namespace, parseConstLabels(constantLabels)),
DB: db,
}
}
Expand All @@ -276,6 +282,9 @@ func queryNamespaceMapping(ch chan<- prometheus.Metric, db *sql.DB, namespace st

defer rows.Close()

//add constant labels


var columnNames []string
columnNames, err = rows.Columns()
if err != nil {
Expand Down Expand Up @@ -631,6 +640,33 @@ func parseStatusField(value string) float64 {
return 0.0
}


func parseConstLabels(s string) prometheus.Labels {
labels := make(prometheus.Labels)

s = strings.TrimSpace(s)
if len(s) == 0 {
return labels
}

parts := strings.Split(s, ",")
for _, p := range parts {
keyValue := strings.Split(strings.TrimSpace(p), "=")
if len(keyValue) != 2 {
level.Error(Logger).Log(`Wrong constant labels format, should be "key=value"`, "input", p)
continue
}
key := strings.TrimSpace(keyValue[0])
value := strings.TrimSpace(keyValue[1])
if key == "" || value == "" {
continue
}
labels[key] = value
}

return labels
}

// Mask user password in DSN
func MaskPassword(dsn string) string {
pDSN, err := url.Parse(dsn)
Expand Down Expand Up @@ -797,7 +833,7 @@ func (e *Exporter) scrape(ch chan<- prometheus.Metric) {
}

// Turn the MetricMap column mapping into a prometheus descriptor mapping.
func makeDescMap(metricMaps map[string]map[string]ColumnMapping, namespace string) map[string]MetricMapNamespace {
func makeDescMap(metricMaps map[string]map[string]ColumnMapping, namespace string, constantLabels prometheus.Labels) map[string]MetricMapNamespace {
var metricMap = make(map[string]MetricMapNamespace)

for metricNamespace, mappings := range metricMaps {
Expand All @@ -824,15 +860,15 @@ func makeDescMap(metricMaps map[string]map[string]ColumnMapping, namespace strin
case COUNTER:
thisMap[columnName] = MetricMap{
vtype: prometheus.CounterValue,
desc: prometheus.NewDesc(fmt.Sprintf("%s_%s_%s", namespace, metricNamespace, columnName), columnMapping.description, variableLabels, nil),
desc: prometheus.NewDesc(fmt.Sprintf("%s_%s_%s", namespace, metricNamespace, columnName), columnMapping.description, variableLabels, constantLabels),
conversion: func(in interface{}) (float64, bool) {
return dbToFloat64(in)
},
}
case GAUGE:
thisMap[columnName] = MetricMap{
vtype: prometheus.GaugeValue,
desc: prometheus.NewDesc(fmt.Sprintf("%s_%s_%s", namespace, metricNamespace, columnName), columnMapping.description, variableLabels, nil),
desc: prometheus.NewDesc(fmt.Sprintf("%s_%s_%s", namespace, metricNamespace, columnName), columnMapping.description, variableLabels, constantLabels),
conversion: func(in interface{}) (float64, bool) {
return dbToFloat64(in)
},
Expand Down