ext/session/mod_mm.c: add a few missing ZSTR macros #20772
Conversation
|
I'm confused. eaee504 went into PHP 8.5 and above, but your PR targets PHP 8.3 ? |
orlitzky
force-pushed
the
mm-zstr-macros
branch
from
25c5d39 to
e30682a
Compare
orlitzky
requested review from
DanielEScherzer,
NattyNarwhal,
SakiTakamachi,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
kamil-tekiela,
kocsismate,
ndossche,
youkidearitai and
zeriyoshi
as code owners
In eaee504 the session's save_path global was changed to a zend_string pointer, but there are a few direct char-pointer accesses in ext/session/mod_mm.c that slipped through the cracks. GCC-15 notices them and fails to build due to the incompatible pointer types. Three ZSTR_* wrappers are all that is needed. Gentoo-Bug: https://bugs.gentoo.org/967862
orlitzky
force-pushed
the
mm-zstr-macros
branch
from
e30682a to
894a5c4
Compare
|
FFS. Sorry for the chaos. You're not confused, I wasn't paying enough attention. I thought I knew which commit introduced the change.... wrote the patch, based it on 8.3, then realized that it was some other commit that actually introduced the change. But I forgot to check that the other (real) commit was in 8.3. |
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Thanks for fixing this, I thought we built all the different session modules but turns out we don't...
|
mm is on the way out next time we can get rid of it though, I thought? |
ndossche
removed request for
DanielEScherzer,
NattyNarwhal,
SakiTakamachi,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
kocsismate,
youkidearitai and
zeriyoshi
IIRC David was working on a replacement using a different library that provides essentially the same functionality. |
|
Thanks! In case anyone is wondering, I don't use this myself or know anyone who does. The developer who reported the bug runs a tinderbox, building random packages in random configurations to find problems before our end users do. It's better to have it working in the meantime but if it gets replaced or nuked, that's fine too. |
That's awesome. I hope the person in question gets some props for their good work. |
5 participants
In https://github.com/php/php-src/commits/eaee504c4d4f337df11b56c251aaeec032b1ea51 the session's
save_pathglobal was changed to azend_stringpointer, but there are a few direct char-pointer accesses inext/session/mod_mm.cthat slipped through the cracks. GCC-15 notices them and fails to build due to the incompatible pointer types. ThreeZSTR_*wrappers are all that is needed.Gentoo-Bug: https://bugs.gentoo.org/967862