Skip to content

Remember resolved types after pushInFunctionCall #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
staabm wants to merge 3 commits into
base: 2.1.x
Choose a base branch
from
Draft

Remember resolved types after pushInFunctionCall #4648

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c75a8b8
Remember resolved types after pushInFunctionCall
staabm Dec 21, 2025
26da905
Update MutatingScope.php
staabm Dec 21, 2025
418647d
Update MutatingScope.php
staabm Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Analyser/MutatingScope.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,7 +2927,7 @@ public function pushInFunctionCall($reflection, ?ParameterReflection $parameter)
$stack = $this->inFunctionCallsStack;
$stack[] = [$reflection, $parameter];

return $this->scopeFactory->create(
$functionScope = $this->scopeFactory->create(
$this->context,
$this->isDeclareStrictTypes(),
$this->getFunction(),
Expand All @@ -2945,14 +2945,16 @@ public function pushInFunctionCall($reflection, ?ParameterReflection $parameter)
$this->parentScope,
$this->nativeTypesPromoted,
);
$functionScope->resolvedTypes = $this->resolvedTypes;
return $functionScope;
}

public function popInFunctionCall(): self
{
$stack = $this->inFunctionCallsStack;
array_pop($stack);

return $this->scopeFactory->create(
$parentScope = $this->scopeFactory->create(
$this->context,
$this->isDeclareStrictTypes(),
$this->getFunction(),
Expand All @@ -2970,6 +2972,8 @@ public function popInFunctionCall(): self
$this->parentScope,
$this->nativeTypesPromoted,
);
$parentScope->resolvedTypes = $this->resolvedTypes;
return $parentScope;
}

/** @api */
Expand Down
Loading