Skip to content

fix(ruby) #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhheider merged 1 commit into from
May 8, 2025
Merged

fix(ruby) #9152

jhheider merged 1 commit into from
May 8, 2025

Conversation

@scottjg
Copy link
Contributor

@scottjg scottjg commented Apr 13, 2025

closes #8718

scottjg added a commit to scottjg/brewkit that referenced this pull request Apr 13, 2025
@scottjg
fix(bk): ignore dsyms in fixer
2a2d9ec 
cc pkgxdev/pantry#9152
@scottjg scottjg mentioned this pull request Apr 13, 2025
Merged
jhheider
jhheider reviewed Apr 13, 2025
View reviewed changes
@jhheider
Copy link
Contributor

jhheider commented Apr 13, 2025

assuming this needs pkgxdev/brewkit#330, i'm optimistic that'll pass review. i appreciate the help!

not to be greedy, but if you wanted to look at the recent rubygems failures (i'm no rubynista), help is always welcome and appreciated.

@scottjg
Copy link
Contributor Author

scottjg commented Apr 14, 2025

not to be greedy, but if you wanted to look at the recent rubygems failures (i'm no rubynista), help is always welcome and appreciated.

took an initial look, but might need some guidance: #9150 (comment)

@scottjg scottjg force-pushed the fix-ruby34-build branch 3 times, most recently from b087b00 to f9d46c6 Compare April 14, 2025 06:11
scottjg
scottjg commented Apr 14, 2025
View reviewed changes
projects/ruby-lang.org/package.yml Outdated
- patch -p1 -F5 < props/mkconfig.rb.diff

- ./configure $ARGS
- CC=cc CXX=cxx ./configure $ARGS
Copy link
Contributor Author

@scottjg scottjg Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should fix the rubygems package native compilation

mxcl pushed a commit to pkgxdev/brewkit that referenced this pull request Apr 14, 2025
@scottjg @mxcl
fix(bk): ignore dsyms in fixer
da52994 
cc pkgxdev/pantry#9152
@scottjg
Copy link
Contributor Author

scottjg commented Apr 15, 2025

now that the brewkit fix is merged, does it need to be released for ci to pick up the fix?

@jhheider
Copy link
Contributor

jhheider commented Apr 15, 2025

yup, it'll require a release.

@scottjg
Copy link
Contributor Author

scottjg commented Apr 27, 2025

i guess brewkit hasn't had a release in some time. any chance i could trouble you to do another one with the fix?

@jhheider jhheider mentioned this pull request May 8, 2025
Closed
This was linked to issues May 8, 2025
❌ build issues: ruby-lang.org=3.4.3 #9157
Closed
Please build Ruby 3.4.3 #9365
Closed
@jhheider
Copy link
Contributor

jhheider commented May 8, 2025

ydm, @scottjg ! thanks for this!

@jhheider jhheider merged commit 290824b into pkgxdev:main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhheider jhheider jhheider left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please build Ruby 3.4.3 ❌ build issues: ruby-lang.org=3.4.3 ❌ build issues: ruby-lang.org=3.4.2

2 participants

@scottjg @jhheider