Remove the operation from the history when the splat is removed

[mmjinglin163]

Remove the operation from the history when the splat is removed

[Copilot]

Pull Request Overview

This PR adds functionality to clean up edit history when elements are removed from the scene. When a splat (element) is deleted, the corresponding operations in the edit history are automatically removed to prevent memory leaks and maintain history consistency.

Key changes:

• Added event handler for scene.elementRemoved to trigger history cleanup
• Implemented removeBySplat method to filter out operations related to deleted elements
• Added proper cursor adjustment and event firing after history cleanup

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/editor.ts	Added event listener to handle element removal and trigger history cleanup
src/edit-history.ts	Added removeBySplat method to remove operations associated with deleted elements

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment is in Chinese. Consider using English for consistency with the rest of the codebase: // Handle MultiOp

Suggested change

	// 处理 MultiOp
	// Handle MultiOp

[Copilot]

Using any type casting defeats TypeScript's type safety. Consider defining a proper interface for MultiOp or use a type guard to check for the ops property more safely.

[slimbuck]

Thanks so much for this PR.

I will hopefully get a chance to test and merge it within the next few days!

[slimbuck]

Hey @mmjinglin163 ,

I would like to suggest a few changes to this PR:

• register for scene.elementRemoved directly in EditHistory constructor
• add a function toEditOp interface for testing whether it applies to the supplied Element instance
• implement the function where necessary for StateOp and MultiOp

What do you think, does this sound reasonable?

If you could make these changes that would be great, otherwise I can too.

Thanks again!

[mmjinglin163]

You're right—these changes will make the structure cleaner and reduce coupling.