-
Notifications
You must be signed in to change notification settings - Fork 22
Menu #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EnricoCorrea
wants to merge
82
commits into
profpantoja:wip-menu-system
Choose a base branch
from
Nilokrtz:wip-menu-system
base: wip-menu-system
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Menu #89
EnricoCorrea
wants to merge
82
commits into
profpantoja:wip-menu-system
from
Nilokrtz:wip-menu-system
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to right or left
Adds Energy Bar System
…ionality-counter-for-collectables-items Feature new functionality counter for collectables items
profpantoja
requested changes
Jul 22, 2025
Owner
profpantoja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Na classe Engine existe um enum gameStatus que já existe na classe Game. Agora toda a lógica, incluindo o switch, está dentro do loop. O interessante é que a classe Game tenha um atributo Menu.
- O Menu não pode ter um método draw, passando o JavaFXDrawer pois não é de responsabilidade do Menu desenhar na tela com algo específico do JavaFx. O draw tem que vir pelo mediator e o mediator fazer a chamada do JavaFxDrawer.
- A mesma coisa funciona com as teclas. Todo comportamento das teclas está dentro do game.loop(). Toda essa dinâmica deve ser tratada lá.
- É importante ter uma classe Menu que seja pai e classes Menus mais concretas.
- Não se pode ter dois ENUMs dentro de uma classe. Tenha duas classes que sejam ENUM (2 enums em arquivo .java). Um outro detalhe é que o Menu tem que ser customizável na criação das instâncias. O ENUM deixará fixo. Prefira entrada em textos customizáveis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Arrow functions eliminated
-Menu logic implemented outside the engine
referente a issue #70