Model STs in Persistence #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejMina226
requested review from
maht0rz and
rpanic
and removed request for
rpanic
Member
|
Another very important thing: We need to add the new tables to the PrismaDatabase's |
rpanic
reviewed
Mar 26, 2025
packages/persistance/src/services/prisma/mappers/StateTransitionMapper.ts
Outdated
Show resolved
Hide resolved
| DBStateTransitionBatch, | ||
| "txExecutionResultId" | "id" | "blockId" | "blockResultId" | ||
| >; | ||
| export type STBatchArrayMapOut2 = Omit<DBStateTransition, "batchId" | "id">[]; |
Member
There was a problem hiding this comment.
Generally, I like this pattern of re-defining the types that are derived from the Prisma types. I see that there are a lot of (by now too complicated) types that do this, can we extract them into those reusable defintions where it makes sense? Might make stuff more readable, especially at places where we stich them together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing the STs and STBatches as json in a table, which makes them hard to query, we now create separate tables to store the information. This also requires changes to the mappers.