-
Notifications
You must be signed in to change notification settings - Fork 11
Add Paraview color maps #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 95.54% 95.55% +0.01%
==========================================
Files 167 168 +1
Lines 2176 2181 +5
==========================================
+ Hits 2079 2084 +5
Misses 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tlambert03 I also added the Do you think it would make sense to remove the |
tlambert03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you find any license information that we could add to this data? (if not, leaving it blank is indeed the correct approach)
also, it would be great if you could put your brief blurb about each colormap (explaining the intention/design principles) under the "info" key for the corresponding colormap (that way it will show up on the docs/website)
I'm a little torn on this one. maybe let's leave it duplicated for now. |
src/cmap/data/paraview/record.json
Outdated
| "Kenneth Moreland" | ||
| ], | ||
| "category": "diverging", | ||
| "data": "cmap.data.paraview:fast", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "data": "cmap.data.paraview:fast", | |
| "data": "cmap.data.paraview:coolwarm" |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually... after re-reading your comment in the original post, I think the value was right, but the key in the colormap is wrong (based on the authors here). Please fix one way or the other though
src/cmap/data/paraview/record.json
Outdated
| "Kenneth Moreland" | ||
| ], | ||
| "category": "diverging", | ||
| "data": "cmap.data.paraview:coolwarm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "data": "cmap.data.paraview:coolwarm", | |
| "data": "cmap.data.paraview:fast", |
?
|
@tlambert03 done! |
|
there's still an issue here. Note how in record.json |
|
Should be fixed now |
This PR creates the ParaView namespace and adds four new color maps obtained from Kenneth Moreland's website:
fastfastis a diverging color map, by Francesca Samsel, W. Alan Scott, and Kenneth Moreland. A paper describing the creation of this color map can be found in "A New Default Colormap for ParaView".kindlmannThis is a modified version of the color map described by Kindlmann et al. to make it perceptually uniform.
blackbody