Skip to content

gh-142939: difflib.get_close_matches performance #142940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dg-pb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-142939: difflib.get_close_matches performance #142940

dg-pb wants to merge 1 commit into from
+9 −7

Conversation

@dg-pb
Copy link
Contributor

@dg-pb dg-pb commented Dec 18, 2025 •
edited
Loading 

S="
from difflib import get_close_matches
possibilities = [f'word{i}' for i in range(1000)]
"

$PYEXE -m timeit -s $S 'get_close_matches("word", possibilities)'
# current - 8.0 ms
# after `ratio()` - 7.2 ms
# after `__contains__` - 6.9 ms

@bedevere-app bedevere-app bot mentioned this pull request Dec 18, 2025
Open
johnslavik
johnslavik approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@johnslavik johnslavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is now simpler, nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@johnslavik johnslavik johnslavik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dg-pb @johnslavik