Skip to content

gh-143513: Clarify changed argument name of ResourceReader.is_resource() #143523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 1 commit into from
Jan 8, 2026
Merged

gh-143513: Clarify changed argument name of ResourceReader.is_resource() #143523

ZeroIntensity merged 1 commit into from
Jan 8, 2026

Conversation

@moreati
Copy link
Contributor

@moreati moreati commented Jan 7, 2026 •
edited by github-actions bot
Loading

@moreati moreati requested review from jaraco and warsaw as code owners January 7, 2026 15:45
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jan 7, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jan 7, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 7, 2026
Open
2 tasks
@moreati
Copy link
Contributor Author

moreati commented Jan 7, 2026

https://cpython-previews--143523.org.readthedocs.build/en/143523/library/importlib.resources.abc.html#importlib.resources.abc.ResourceReader.is_resource

ZeroIntensity
ZeroIntensity approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 8, 2026
@ZeroIntensity ZeroIntensity merged commit 5462002 into python:main Jan 8, 2026
43 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jan 8, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 8, 2026

Thanks @moreati for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2026
@moreati @miss-islington
pythongh-143513: Clarify changed argument name of `ResourceReader.is_…
5d7c09d 
…resource` (pythonGH-143523)

(cherry picked from commit 5462002)

Co-authored-by: Alex Willmer <alex@moreati.org.uk>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2026
@moreati @miss-islington
pythongh-143513: Clarify changed argument name of `ResourceReader.is_…
69f0d53 
…resource` (pythonGH-143523)

(cherry picked from commit 5462002)

Co-authored-by: Alex Willmer <alex@moreati.org.uk>
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2026

GH-143562 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 8, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2026

GH-143563 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 8, 2026
ZeroIntensity pushed a commit that referenced this pull request Jan 8, 2026
@miss-islington @moreati
[3.14] gh-143513: Clarify changed argument name of `ResourceReader.is…
6c6eb7a 
…_resource` (GH-143523) (GH-143562)

gh-143513: Clarify changed argument name of `ResourceReader.is_resource` (GH-143523)
(cherry picked from commit 5462002)

Co-authored-by: Alex Willmer <alex@moreati.org.uk>
ZeroIntensity pushed a commit that referenced this pull request Jan 8, 2026
@miss-islington @moreati
[3.13] gh-143513: Clarify changed argument name of `ResourceReader.is…
bcc0552 
…_resource` (GH-143523) (GH-143563)

gh-143513: Clarify changed argument name of `ResourceReader.is_resource` (GH-143523)
(cherry picked from commit 5462002)

Co-authored-by: Alex Willmer <alex@moreati.org.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreati @ZeroIntensity