gh-143547: Fix PyErr_FormatUnraisable() fallback #143557
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure. Fix test_sys.UnraisableHookTest: use the right decorator function to disable colors. Previously, tests were always skipped.
vstinner
added
needs backport to 3.13
aisk
reviewed
Jan 8, 2026
ZeroIntensity
approved these changes
Jan 8, 2026
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
This looks user-facing, so I think it would be a good idea to add a news entry, but I'll leave the decision up to you. The rest of the PR looks good to me.
Member
Author
Ok, I added a NEWS entry. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @vstinner, I could not cleanly backport this to |
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-143603 is a backport of this pull request to the 3.14 branch. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Jan 9, 2026
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure. (cherry picked from commit 39a2bcf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure.
Fix test_sys.UnraisableHookTest: use the right decorator function to disable colors. Previously, tests were always skipped.
sys.unraisablehookfails and falls back to default logger #143547