Add vernacular names of languages #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rffontenelle
suggested changes
Jan 24, 2025
Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
rffontenelle
approved these changes
Jan 24, 2025
config.toml
Outdated
|
|
||
| [languages.pt_BR] | ||
| name = "Brazilian Portuguese" | ||
| name = "Português brasileiro (Brazilian Portuguese)" |
Member
There was a problem hiding this comment.
Any reason why this is capitalized but the previous ones aren't?
Contributor
There was a problem hiding this comment.
Because I requested to capitalize de letter P. Even though the language names in Brazilian Portuguese are not proper names, I considered that since it is not in the middle of a sentence it would be better to have the P capitalized
Member
Author
There was a problem hiding this comment.
@ezio-melotti I approved @rffontenelle change as he is a speaker.
egeakman
approved these changes
Jan 24, 2025
Contributor
egeakman
left a comment
egeakman
left a comment
There was a problem hiding this comment.
Turkish part looks good to me.
# Conflicts: # config.toml
Member
Author
|
Replaced with what seems to be more popular. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#238
Used google.com's switcher.
There is currently preference to the format: vernacularName (EnglishTranslation) however I have just vernacularName ready to commit if that is more preferred.