Add Iterator.zipKeyed #1277
Open
Add Iterator.zipKeyed #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
commented
Dec 20, 2025
| @@ -0,0 +1,194 @@ | |||
| ;(function(IteratorHelper, InternalError, TypeError, call, | |||
| hasOwnEnumProperty, getOwnProperties, Symbol·iterator) { | |||
Contributor
Author
There was a problem hiding this comment.
I should come up with a better name for getOwnProperties because it:
- suggests it's like
Object.getOwnPropertieswhen it's not, and - doesn't just look up properties but also symbols
Suggestions welcome.
Contributor
There was a problem hiding this comment.
How about getOwnPropertyKeys, like the spec calls it? https://tc39.es/ecma262/#sec-getownpropertykeys
saghul
approved these changes
Jan 5, 2026
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM with a suggestion. Also, as an additional soft suggestion, drop the mid period from the property names, I thought it was some kind of bug!
| @@ -0,0 +1,194 @@ | |||
| ;(function(IteratorHelper, InternalError, TypeError, call, | |||
| hasOwnEnumProperty, getOwnProperties, Symbol·iterator) { | |||
Contributor
There was a problem hiding this comment.
How about getOwnPropertyKeys, like the spec calls it? https://tc39.es/ecma262/#sec-getownpropertykeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is #1274.