Update requirements.txt #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on python versions 3.7 or higher, and the dataclasses package is designed as a: 'backport for Python 3.6'.
|
Can this please be merged |
|
A merge would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pypi package dataclasses is designed as a backport for python 3.6. For python 3.7 and above, it is included in python itself. Thus, it isn't necessary for later python versions, and for windows 10 for example, this additional installation can confuse python. I'm currently experiencing an error related to that.
If we tweak requirements.txt to only install dataclasses for python 3.6 or lower, that issue for windows users goes away, and we have one less dependency, which is nice.
Edit: Another option is to just remove that line entirely, as it seems the latest PR has dropped this project's support for python 3.6?