ROI_number attribution

[FabienRech]

When trying to automatize addition of ROI in several RTstructure files, one problem is that ROI number in RTstructure might differ and are not successive (sometime going from 10 to 50).
Here is a proposition to check if the ROI number exists and give an original ROI number to prevent error in opening of the RT
structure in software.

[asim-shrestha]

Hey thanks for tackling this! We should write some tests for this if possible :)

Scenarios:

• Adding an roi with no existing ROIs
• Adding an roi when there are existing ROI(s) but there is no number conflict
• Adding an roi when there are existing ROI(s) but there are number conflicts

[asim-shrestha]

Comment should be placed after the function declaration

def roi_number(self):
    """
    choose a ROI number which has not been attributed to the ROI already existing the original RTstructure. This might prevent duplicate and error in opening
    """

[asim-shrestha]

We can use list comprehension here to simplify

Suggested change

	ROI_list = self.ds.StructureSetROISequence
	ROI_number = []
	for i in range(len(ROI_list)):
	ROI_number.append(ROI_list[i].ROINumber.numerator)
	roi_numbers = [roi.ROINumber.numerator for roi in self.ds.StructureSetROISequence ]

note we have been using lowercase for ROI, we should remain consistent

[asim-shrestha]

Side note, it looks like some existing unit tests are failing, will need to update those

Also, this looks like it has all of your previous commits that have been merged in, perhaps you need to sync your fork with the mainline repo

[FabienRech]

Thank you for your answer.
I will check that in few days, I am not familiar with Github so I could have made a lot of mistakes.