footnote: add margin-note and backlink support #545
+519
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 5 files in this pull request and found no issues.
Support a `#:margin` mode for `define-footnote` as an alternative to putting footnotes in a section created by a `footnote-part` identifier that is bound by `define-footnote`. The margin format is defined by default CSS, and different CSS magic could make cause a "margin note" to actually render differently. At the footnote, hyperlink its number back to the reference to the footnote, as as typical for many web sites with footnotes. Use `scriblib/render-cond` to specialie Latex output and avoid the double inclusion of content previously warned against in the documentation. Meanwhile, warn against limitations of creating footnotes inside footnotes. For testing, use a strategy that has worked well for Rhombus Scribble (and that probably should be made more reusable).
mflatt
force-pushed
the
margin-footnote
branch
from
9509ea8 to
96ab306
Compare
There was a problem hiding this comment.
Resyntax analyzed 5 files in this pull request and found no issues.
Contributor
|
Does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ideas and discussion in #543.
Support a
#:marginmode fordefine-footnoteas an alternative to putting footnotes in a section created by afootnote-partidentifier that is bound bydefine-footnote. The margin format is defined by default CSS, and different CSS magic could make cause a "margin note" to actually render differently.At the footnote, hyperlink its number back to the reference to the footnote, as as typical for many web sites with footnotes.
For testing, use a strategy that has worked well for Rhombus Scribble (and that probably should be made more reusable).