Fix variable counter keep changing on downgrade on DowngradeNullsafeToTernaryOperatorRector #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oTernaryOperatorRector
Member
Author
|
All checks have passed 🎉 @TomasVotruba let's merge it for faster feedback to test ;) This is ensure counter reset when move to other file so the increment will consistent, previously it was always changed, and as parallel, it keep changing randomly accross files. This PR fix it :) |
Member
Author
|
It works ok now 👍 , when move to other file, the counter reset and increment in the new file rectorphp/rector@547afbd |
| if ($currentFile !== $this->file->getFilePath()) { | ||
| $this->counter = 0; | ||
| $currentFile = $this->file->getFilePath(); | ||
| } |
Member
There was a problem hiding this comment.
Could you add a simple comment on "why" is this needed? Just for future reference
Member
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #355 (review)
This ensure increment variable to consistent accroos downgrade process, avoid keep changing on downgrade as run in parallel.