Skip to content

[internal] Traverse DecoratingNodeVisitorInterface after scope filling on PHPStanNodeScopeResolver::processNodes() #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 3 commits into from
Dec 7, 2025
Merged

[internal] Traverse DecoratingNodeVisitorInterface after scope filling on PHPStanNodeScopeResolver::processNodes() #7729

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0411b4b
[internal] Traverse DecoratingNodeVisitorInterface after scope fillin…
samsonasik Dec 7, 2025
bad6f94
fix grammar
samsonasik Dec 7, 2025
5a6c060
add link comment
samsonasik Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ public function processNodes(

Assert::allIsInstanceOf($stmts, Stmt::class);

$this->nodeTraverser->traverse($stmts);

$scope = $formerMutatingScope ?? $this->scopeFactory->createFromFile($filePath);

$nodeCallback = function (Node $node, MutatingScope $mutatingScope) use (
Expand Down Expand Up @@ -419,6 +417,10 @@ public function processNodes(
RectorNodeScopeResolver::processNodes($stmts, $scope);
}

// use after scope filling so DecoratingNodeVisitorInterface instance can fetch the scope of target node
// @see https://github.com/rectorphp/rector-src/pull/7721#discussion_r2595932460
$this->nodeTraverser->traverse($stmts);

return $stmts;
}

Expand Down