[DeadCode] Skip with different default param value child vs parent on RemoveParentDelegatingConstructorRector #7776
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RemoveParentDelegatingConstructorRector
samsonasik
force-pushed
the
skip-deif
branch
from
f2dd62b to
5c398e3
Compare
Member
Author
|
Fixed 🎉 /cc @franck-paul |
Member
Author
|
@TomasVotruba ready 👍 |
|
Nice, it's Christmas before Christmas \o/ |
| if ($parentDefault !== $currentDefault) { | ||
| return false; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Looks good 👍
Could you extract method here to make code more readable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9571