Skip to content

Error with merged carbon imports with importNames and removeUnusedImports. #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BinaryKitten wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Error with merged carbon imports with importNames and removeUnusedImports. #7811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2047101
Add test case for issue with Carbon import
BinaryKitten Jan 6, 2026
273dd59
fix fixture php line to enable clearer error showing
BinaryKitten Jan 6, 2026
69b8163
Second example with Illuminate\Support\Carbon
BinaryKitten Jan 6, 2026
db15f5c
rename test files after discussion
BinaryKitten Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .../RenameClassRector/FixtureAutoImportNames/error_merged_import_property_annotation.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php
Copy link
Member

@samsonasik samsonasik Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only for autoimport + remove, nothing todo with rename, so you can move these fixture tests to tests/Issues/NamespacedUseAutoImport which only check on this functionality for auto import + remove unused import:

https://github.com/rectorphp/rector-src/tree/main/tests/Issues/NamespacedUseAutoImport/Fixture


declare(strict_types=1);

namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source;

use Carbon\Carbon;
use Carbon\CarbonInterface;

/**
* @property \Carbon\CarbonInterface|null $deleted_at
*/
class MergedImportError
{
public function demoFunction(): array
{
return [Carbon::parse('2026-01-01 11:16:01')];
}
}

?>
-----
<?php

declare(strict_types=1);

namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source;

use Carbon\Carbon;
use Carbon\CarbonInterface;

/**
* @property CarbonInterface|null $deleted_at
*/
class MergedImportError
{
public function demoFunction(): array
{
return [Carbon::parse('2026-01-01 11:16:01')];
}
}

?>
43 changes: 43 additions & 0 deletions ...enameClassRector/FixtureAutoImportNames/error_merged_import_property_annotation_2.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

declare(strict_types=1);

namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source;

use Illuminate\Support\Carbon;
use Carbon\CarbonInterface;

/**
* @property \Carbon\CarbonInterface|null $deleted_at
*/
class MergedImportErrorOtherVariety
{
public function demoFunction(): array
{
return [Carbon::parse('2026-01-01 11:16:01')];
}
}

?>
-----
<?php

declare(strict_types=1);

namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source;

use Illuminate\Support\Carbon;
use Carbon\CarbonInterface;

/**
* @property CarbonInterface|null $deleted_at
*/
class MergedImportErrorOtherVariety
{
public function demoFunction(): array
{
return [Carbon::parse('2026-01-01 11:16:01')];
}
}

?>
Loading