Skip to content

Reducing duplicate code. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheRealVira wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reducing duplicate code. #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions indicator-fast-scroll/src/main/java/com/reddit/indicatorfastscroll/FastScrollerThumbView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,13 @@ class FastScrollerThumbView @JvmOverloads constructor(
) {
val thumbTargetY = indicatorCenterY.toFloat() - (thumbView.measuredHeight / 2)
thumbAnimation.animateToFinalPosition(thumbTargetY)

when (indicator) {
is FastScrollItemIndicator.Text -> {
textView.isVisible = true
iconView.isVisible = false

textView.text = indicator.text
}
is FastScrollItemIndicator.Icon -> {
textView.isVisible = false
iconView.isVisible = true

iconView.setImageResource(indicator.iconRes)
}

textView.isVisible = indicator is FastScrollItemIndicator.Text
iconView.isVisible = !textView.isVisible

when (textView.isVisible) {
true -> textView.text = indicator.text
false -> iconView.setImageResource(indicator.iconRes)
}
}
}