Skip to content

[DRAFT] Initial React "concurrent stores" compat prototype #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
markerikson wants to merge 18 commits into
base: master
Choose a base branch
from
+1,591 −46
Draft

[DRAFT] Initial React "concurrent stores" compat prototype #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
080450f
Add react-concurrent-store dep
markerikson Oct 31, 2025
fadb4c7
Allow committing Yalc'd packages
markerikson Oct 31, 2025
764e3cb
Add Yalc'd react-concurrent-store with TS fixes
markerikson Oct 31, 2025
0cda5b3
Fix tsconfig moduleResolution
markerikson Oct 31, 2025
d1dbe94
Add reactStore enhancer
markerikson Oct 31, 2025
5b5b47e
Fix react enhancer types
markerikson Oct 31, 2025
fb153ff
Update provider and Context
markerikson Oct 31, 2025
dc02c71
Rewrite useSelector with concurrent compat and wrapper behavior
markerikson Oct 31, 2025
73495d2
Add store test util
markerikson Oct 31, 2025
8d6f42b
Use React-compat stores in useSelector tests
markerikson Oct 31, 2025
41c02ba
Update `useSelector` tests with current selector call counts and expe…
markerikson Oct 31, 2025
09def2d
Differentiate `uSESWS` impls
markerikson Dec 2, 2025
5864f7d
Update RCS Yalc build
markerikson Dec 22, 2025
05db788
Use useStoreSelectorWithEquality in useSelector
markerikson Dec 22, 2025
801f85d
Update selector call assertions
markerikson Dec 22, 2025
b295a62
Update remaining test expectations
markerikson Dec 22, 2025
a48983d
Work around Yarn + Yalc lockfile changes
markerikson Dec 22, 2025
f61070a
Remove dead selector refs
markerikson Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:

- name: Install dependencies
run: yarn install
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Lint
run: yarn lint
Expand Down Expand Up @@ -83,15 +85,23 @@ jobs:

- name: Install deps
run: yarn install
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Install React ${{ matrix.react.version }} and React-DOM ${{ matrix.react.react-dom.version }}
run: yarn add -D react@${{ matrix.react.version }} react-dom@${{ matrix.react.react-dom.version }} @types/react@${{ matrix.react.types }} @types/react-dom@${{ matrix.react.react-dom.types }}
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Install TypeScript ${{ matrix.ts }}
run: yarn add typescript@${{ matrix.ts }}
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Install build artifact
run: yarn add ./package.tgz
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Erase path aliases
run: sed -i -e /@remap-prod-remove-line/d ./tsconfig.base.json
Expand Down Expand Up @@ -176,6 +186,8 @@ jobs:
- name: Install example deps
working-directory: ./redux-toolkit/examples/publish-ci/${{ matrix.example }}
run: yarn install
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Install Playwright browser if necessary
working-directory: ./redux-toolkit/examples/publish-ci/${{ matrix.example }}
Expand All @@ -194,6 +206,8 @@ jobs:
- name: Install build artifact
working-directory: ./redux-toolkit/examples/publish-ci/${{ matrix.example }}
run: yarn add ./package.tgz
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Show installed package versions
working-directory: ./redux-toolkit/examples/publish-ci/${{ matrix.example }}
Expand Down Expand Up @@ -234,6 +248,8 @@ jobs:

- name: Install deps
run: yarn install
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Remove existing React-Redux
run: yarn remove react-redux
Expand All @@ -248,6 +264,8 @@ jobs:

- name: Install build artifact
run: yarn add ./package.tgz
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Show installed React-Redux versions
run: yarn info react-redux && yarn why react-redux
Expand Down Expand Up @@ -289,6 +307,8 @@ jobs:

- name: Install deps
run: yarn install
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Download build artifact
uses: actions/download-artifact@v4
Expand All @@ -301,9 +321,13 @@ jobs:

- name: Install React ${{ matrix.react.version }} and React-DOM ${{ matrix.react.react-dom.version }}
run: yarn add -D react@${{ matrix.react.version }} react-dom@${{ matrix.react.react-dom.version }} @types/react@${{ matrix.react.types }} @types/react-dom@${{ matrix.react.react-dom.types }}
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Install build artifact
run: yarn add ./package.tgz
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Erase path aliases
run: sed -i -e /@remap-prod-remove-line/d ./tsconfig.base.json
Expand Down
14 changes: 7 additions & 7 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
node_modules
dist
lib
coverage
es
/dist*/
/lib/
/coverage/
/es/
temp/
react-redux-*/
redux-toolkit/
Expand All @@ -21,9 +21,9 @@ website/.yarn/
.pnp.*
*.tgz

.yalc
yalc.lock
yalc.sig
#.yalc
#yalc.lock
#yalc.sig

lib/core/metadata.js
lib/core/MetadataBlog.js
Expand Down
Loading
Loading