chore(engine): test actor alarms

[abcxff]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
rivet-cloud	Ignored		Dec 25, 2025 2:49am
rivet-inspector	Ignored	Preview	Dec 25, 2025 2:49am
rivet-site	Ignored	Preview	Dec 25, 2025 2:49am
rivetkit-serverless	Skipped		Dec 25, 2025 2:49am

[abcxff]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(engine): test actors runner kv #3625
• chore(engine): test actor alarms #3624 👈 (View in Graphite)
• feat(engine): actors lifecycle testing #3623
• chore: setup rivet-engine api tests #3540
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: Actor Alarms Test Suite

This PR adds comprehensive test coverage for the actor alarms feature with 1453 lines of tests and test runner infrastructure improvements.

Strengths

1. Comprehensive test coverage for alarms, clearing, replacement, edge cases
2. Well-documented test actor behaviors
3. Added lifecycle event broadcasting for better test observability
4. Clear test organization with MARK comments

Critical Issues (BLOCKING)

1. Import style violation at actors_alarm.rs:1 - uses anyhow::* glob import, prohibited by CLAUDE.md. Fix: use anyhow::{Result, bail};
2. Race condition in wait_for_actor_wake_from_alarm timeout logic (line 75) - saturating_sub can return Duration::ZERO causing immediate timeout

High Priority

3. Poor error handling with nested expect() calls - use ? with Context trait
4. Arc<Mutex<Option>> pattern with unwrap() - simplify or document necessity
5. Silent error handling - let _ = tx.send() should log failures

Nice to Have

• Extract magic numbers to constants
• Document timeout choices
• Consider removing deprecated polling helpers

Test Coverage

Excellent coverage of basic alarms, clearing, replacement, edge cases, multi-cycle patterns, crash interactions, concurrent alarms, and timing accuracy.

Overall: 4/5 stars

Recommendation: Approve with changes - fix glob import and timeout race condition before merging.

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-next-js
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-deno
• example-sqlite
• example-elysia
• example-experimental-durable-streams-ai-agent
• example-express
• example-hono
• hono-bun
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• example-node
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3624

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3624

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3624

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3624

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3624

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3624

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3624

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3624

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3624

commit: 10eacad

[graphite-app]

Merge activity

• Dec 25, 3:10 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Dec 25, 3:10 AM UTC: CI is running for this pull request on a draft pull request (#3676) due to your merge queue CI optimization settings.
• Dec 25, 3:11 AM UTC: Merged by the Graphite merge queue via draft PR: #3676.