Skip to content

Saas and mobile fixes #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 3 commits into from
Dec 24, 2025
Merged

Saas and mobile fixes #1490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5929f1e
Merge branch 'main' into saas-and-mobile-fixes
lyubov-voloshko Dec 22, 2025
00ff8b3
add own IP to the list of saasHostnames in dev vars
lyubov-voloshko Dec 24, 2025
f63a646
Merge branch 'main' into saas-and-mobile-fixes
lyubov-voloshko Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/environments/environment.dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const environment = {
saas: false,
apiRoot: "https://app.rocketadmin.com/api",
saasURL: "https://app.rocketadmin.com",
saasHostnames: ['localhost'],
saasHostnames: ['localhost', '127.0.0.1'],
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding '127.0.0.1' to saasHostnames in the dev environment is a good fix, but the same addition should also be made to environment.saas.ts and environment.saas-prod.ts for consistency. Both of those files currently have saasHostnames arrays with 'localhost' but are missing '127.0.0.1'. This inconsistency could lead to different behavior when the application runs on 127.0.0.1 vs localhost in different environments, even though they resolve to the same address.

Copilot uses AI. Check for mistakes.
stagingHost: "",
version: '0.0.0'
};
Loading