-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor Neo4j ingestion through configurable pipelines #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors Neo4j document ingestion to use configurable LlamaIndex ingestion pipelines, replacing inline document processing with a modular architecture featuring connectors, transformations, and writers.
Key Changes:
- Introduced reusable pipeline components (
ManualDocumentConnector,SimpleFileConnector,SimpleDirectoryConnector,Neo4jKnowledgeGraphWriter, etc.) - Added configuration-driven pipeline management with default bundles and user override support via
ingestion_pipelinessetting - Refactored
add_document,add_file, andadd_directoryto execute through a unified_run_ingestion_pipelinemethod
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/services/test_pipeline_components.py |
Unit tests for pipeline bundle execution and configuration merging |
src/codebase_rag/services/knowledge/pipeline_components.py |
Core pipeline components including connectors, transformations, writers, and configuration builders |
src/codebase_rag/services/knowledge/neo4j_knowledge_service.py |
Refactored service to use pipeline bundles instead of direct document insertion |
src/codebase_rag/config/settings.py |
Added ingestion_pipelines configuration field |
docs/getting-started/configuration.md |
Documentation for customizing ingestion pipelines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
Testing
Codex Task