Skip to content

Conversation

@royisme
Copy link
Owner

@royisme royisme commented Nov 7, 2025

Summary

  • refactor the Neo4j knowledge service to use reusable LlamaIndex ingestion pipelines with connectors, transformations, and writers
  • add a configurable ingestion_pipelines setting plus default pipeline bundle helpers and reusable components
  • document how to customize ingestion pipelines through configuration and cover the new helpers with unit tests (skipped when llama_index cannot be imported)

Testing

  • PYTHONPATH=src pytest tests/services/test_pipeline_components.py

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@royisme royisme requested a review from Copilot November 7, 2025 05:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Neo4j document ingestion to use configurable LlamaIndex ingestion pipelines, replacing inline document processing with a modular architecture featuring connectors, transformations, and writers.

Key Changes:

  • Introduced reusable pipeline components (ManualDocumentConnector, SimpleFileConnector, SimpleDirectoryConnector, Neo4jKnowledgeGraphWriter, etc.)
  • Added configuration-driven pipeline management with default bundles and user override support via ingestion_pipelines setting
  • Refactored add_document, add_file, and add_directory to execute through a unified _run_ingestion_pipeline method

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/services/test_pipeline_components.py Unit tests for pipeline bundle execution and configuration merging
src/codebase_rag/services/knowledge/pipeline_components.py Core pipeline components including connectors, transformations, writers, and configuration builders
src/codebase_rag/services/knowledge/neo4j_knowledge_service.py Refactored service to use pipeline bundles instead of direct document insertion
src/codebase_rag/config/settings.py Added ingestion_pipelines configuration field
docs/getting-started/configuration.md Documentation for customizing ingestion pipelines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

royisme and others added 3 commits November 7, 2025 13:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@royisme royisme merged commit 34eb7bb into main Nov 7, 2025
9 checks passed
@royisme royisme deleted the codex/refactor-neo4j-knowledge-service-pipeline branch November 7, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants