Skip to content

fix ruby_ui-js refs #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethhorsley merged 2 commits into from
Nov 10, 2024
Merged

fix ruby_ui-js refs #188

sethhorsley merged 2 commits into from
Nov 10, 2024

Conversation

@mhamza15
Copy link
Contributor

@mhamza15 mhamza15 commented Nov 9, 2024

In the install generator, there are still some references to the old ruby_ui-js name for the NPM package. This PR updates it to ruby_ui_js.

@mhamza15
Update index.js.tt
7a4eb0f 
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
@mhamza15
Update install_generator.rb
28e5522 
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
sethhorsley
sethhorsley approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@sethhorsley sethhorsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sethhorsley sethhorsley merged commit 3d4e646 into ruby-ui:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethhorsley sethhorsley sethhorsley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhamza15 @sethhorsley