Install component dependencies (gems, stimulus, packages, components) #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirdes
approved these changes
Nov 18, 2024
| - "chart.js" | ||
|
|
||
| checkbox: | ||
| stimulus_controllers: |
Collaborator
There was a problem hiding this comment.
let's remove the stimulus_controllers and we're good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve component generator allowing installing dependencies like another components, js packages, stimulus controllers and ruby gems.
These dependencies are tracked in
dependencies.ymlfile, maybe we could try to analyze component files to discover dependencies, but for now I think it will be simpler to add the dependencies manually to the yaml file.This is an example of an application that RubyUI and Combobox was installed using only our generators (
rails g ruby_ui:installandrails g ruby_ui:component Combobox). It is working 🥳.Screen.Recording.2024-11-18.at.13.28.52.mov