Make generators compatible with importmaps #200
Conversation
| when "motion" | ||
| pin_motion | ||
| when "tippy.js" |
There was a problem hiding this comment.
These two packages didn't play well with importmaps, so I'm pointing to remote cdn. My first take was to download the file and add to vendor/javascript folder and add pin "motion" to config/importmap.rb, but I'm not sure if that was the best option, because it could go wrong if user tried to update/redownload the packages. If think it's safer to point to CDN and let the users download the file if they want.
There was a problem hiding this comment.
@stephannv , this is fine. Tippy.js will be replaced by floating-ui, and motion is used on the Accordion, but I don't think we need any dependency there. In other words, it's fine, and we should remove both dependencies soon.
| if File.exist?(Rails.root.join("tailwind.config.js")) # tailwindcss js package | ||
| template "tailwind.config.js.js-package.erb", Rails.root.join("tailwind.config.js") | ||
| elsif File.exist?(Rails.root.join("config/tailwind.config.js")) # tailwindcss-rails gem | ||
| template "tailwind.config.js.tailwindcss-rails.erb", Rails.root.join("config/tailwind.config.js") | ||
| else |
There was a problem hiding this comment.
Rails apps using importmaps use tailwindcss-rails gem, the config file is located on config folder and uses a slightly different file content but I think it was enough to create 2 separated templates, I think it was easier than trying inject pieces of code conditionally.
| when "motion" | ||
| pin_motion | ||
| when "tippy.js" |
There was a problem hiding this comment.
@stephannv , this is fine. Tippy.js will be replaced by floating-ui, and motion is used on the Accordion, but I don't think we need any dependency there. In other words, it's fine, and we should remove both dependencies soon.
2 participants
Make generators compatible with importmaps. Some js packages I had to point to jsdelivr +esm because using
bin/importmap pin motionwould download the wrong file and get a lot of errors. I'm not sure if there is a way to use correct file usingpincommand.ps. Using this branch I could generate a Rails app from scratch and I could use RubyUI components (+ their javascripts) using only our generators.