Add tailwindcss-animate config #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethhorsley
approved these changes
Nov 19, 2024
Member
sethhorsley
left a comment
sethhorsley
left a comment
There was a problem hiding this comment.
Looks good but we need to make sure things are still working with import maps and esbuild. I remember there was something messing up with importmaps and the animate lib.
Comment on lines
+1
to
+5
| require_relative "javascript_utils" | ||
| module RubyUI | ||
| module Generators | ||
| class ComponentGenerator < Rails::Generators::Base | ||
| include RubyUI::Generators::JavascriptUtils |
Contributor
Author
@sethhorsley yeah, I tested on 2 apps(rails with importmap and rails with esbuild) and the animation worked fine on both apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tailwindcss-animate plugin back to setup installer and moving logic related to javascript packages to a separated module.