Skip to content

Standardize BlockQuote markup #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinistock wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −11
Open

Standardize BlockQuote markup #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/rdoc/markup/block_quote.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# frozen_string_literal: true
##
# A quoted section which contains markup items.

class RDoc::Markup::BlockQuote < RDoc::Markup::Raw

##
# Calls #accept_block_quote on +visitor+

def accept(visitor)
visitor.accept_block_quote self
module RDoc
class Markup
class BlockQuote < Raw
Copy link
Member

@tompng tompng Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need class comment before this line: # A quoted section which contains markup items.

# Calls #accept_block_quote on +visitor+
# @override
#: (untyped) -> void
def accept(visitor)
visitor.accept_block_quote(self)
end
end
end

end
2 changes: 1 addition & 1 deletion lib/rdoc/markup/raw.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module RDoc
class Markup
# A section of text that is added to the output document as-is
class Raw
class Raw < Element
# The component parts of the list
#: Array[String]
attr_reader :parts
Expand Down