[5042] experiment with pulling docx helpers out in favor of letting a gem do it #5043
+158
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeminismIsAwesome
requested review from
FireLemons,
compwron and
littleforest
as code owners
Collaborator
|
Can you check the failing specs? |
littleforest
changed the title
Collaborator
|
Can you double check specs again?! Thanks! |
Collaborator
|
@FeminismIsAwesome please lint! I think the spec failure might be flaky. |
FeminismIsAwesome
force-pushed
the
tech/see-if-we-can-pull-out-custom-helper-class
branch
from
19f350b to
cdbac9f
Compare
FeminismIsAwesome
force-pushed
the
tech/see-if-we-can-pull-out-custom-helper-class
branch
2 times, most recently
from
5f2e3a6 to
7194ebb
Compare
Collaborator
Author
|
@littleforest can you give it another look? fixed the tests (that aren't flakes) |
littleforest
approved these changes
Aug 1, 2023
Collaborator
littleforest
left a comment
littleforest
left a comment
There was a problem hiding this comment.
Looks great! Thanks for working on this.
FeminismIsAwesome
deleted the
tech/see-if-we-can-pull-out-custom-helper-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5042
ruby-docx/docx#137 will make this even simpler once we get that going
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9