Fix templateId not applying disk and volume settings from template #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --templateId is specified, CLI flag defaults (containerDiskSize=20, volumeSize=1, volumePath=/runpod) were overriding template settings. Now these fields are cleared when templateId is set and flags were not explicitly changed by the user, allowing template values to be used. Fixes runpod#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--templateIdis specified, disk/volume settings from template are now used instead of being overwritten by CLI flag defaultsProblem
CLI flags have non-zero defaults (
--containerDiskSize=20,--volumeSize=1,--volumePath=/runpod) that were always sent to the API, overriding template settings even when user didn't explicitly set them.Solution
omitemptytocontainerDiskInGb,volumeInGb,volumeMountPathJSON tagsTemplateFieldFlagsstruct andClearUnchangedTemplateFieldsmethod to clear these fields when templateId is set and flags were not explicitly changedFixes #163