game-activty: ignore APP_CMD_SOFTWARE_KB_VIS_CHANGED w/o panic #215
+60
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rib
force-pushed
the
rib/pr/ignore-app-cmd-software-kb-vis-changed
branch
from
33cdd89 to
72fd038
Compare
APP_CMD_SOFTWARE_KB_VIS_CHANGED in the GameActivity backend is intended for notifying the android_main thread that the soft keyboard visibility has changed. There's currently no Rust event / API for this, and so it wasn't being handled in poll_events but that was leading to a unreachable panic when GameActivity would send this APP_CMD when showing soft keyboards. We don't currently plan to expose any public API / event for this since it's based on monitoring IME insets and applications should instead be able to check insets after getting InsetsChanged events. For the sake of minimizing patches to the upstream GameActivity code this makes it so poll_events can ignore this APP_CMD as a NOOP.
rib
force-pushed
the
rib/pr/ignore-app-cmd-software-kb-vis-changed
branch
from
72fd038 to
2876923
Compare
rib
changed the base branch from
rib/pr/android-games-sdk-4-kbd-vis-editor-actions
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APP_CMD_SOFTWARE_KB_VIS_CHANGEDin theGameActivitybackend is intended for notifying the android_main thread that the soft keyboard visibility has changed.There's currently no Rust event / API for this, and so it wasn't being handled in poll_events but that was leading to a unreachable panic when
GameActivitywould send this APP_CMD when showing soft keyboards.We don't currently plan to expose any public API / event for this since it's based on monitoring IME insets and applications should instead be able to check insets after getting
InsetsChangedevents.For the sake of minimizing patches to the upstream
GameActivitycode this makes it so poll_events can ignore thisAPP_CMDas a NOOP.Closes: #212