Minimal changes to build with Rust 1.91 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Approximately: - Replaced `array_chunks` usage with `Itertools::chunks`, which isn't a _totally_ drop-in replacement, but should be sufficient here. - Removed the other nightly flag completely, since it was unused. - Annotated unused functions with `#[expect(unused)]` so they changes either be removed later, or those annotations can be removed when they are in use. - Removed placeholder docblocks in error enums, since they were causing errors. - Accepted various other Clippy suggestions, none of which were particularly interesting.
LawnGnome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably requires #10 in practice, but in theory is separate. Turns out clippy and rustc gained new lints!
Approximately:
array_chunksusage withItertools::chunks, which isn't a totally drop-in replacement, but should be sufficient here.#[expect(unused)]so they changes either be removed later, or those annotations can be removed when they are in use.I'm also fine if we also want to turn down some of the clippy lints.