Skip to content

Fix linting errors blocking PRs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhit-silkaijr merged 15 commits into from
Nov 4, 2025
Merged

Fix linting errors blocking PRs #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1ac1e12
Testing updated golangci version
rhit-silkaijr Oct 28, 2025
e08c97b
removing typecheck
rhit-silkaijr Oct 28, 2025
85807ec
Further removing checks + v1.61
rhit-silkaijr Oct 28, 2025
c95535d
Testing downgrade
rhit-silkaijr Oct 28, 2025
5d33bf3
Undoing downgrade
rhit-silkaijr Oct 28, 2025
bd55533
Testing newest version
rhit-silkaijr Oct 28, 2025
b16bac7
Testing newest v1
rhit-silkaijr Oct 28, 2025
27d603f
testing v1.62.0
rhit-silkaijr Oct 28, 2025
020e604
Checking if highest version works still
rhit-silkaijr Oct 28, 2025
71e9325
v1.64.2 test
rhit-silkaijr Oct 28, 2025
ffa10a0
v1.63.0 test
rhit-silkaijr Oct 28, 2025
b1892ea
v1.62.2
rhit-silkaijr Oct 28, 2025
20cbd04
testing false check shadowing
rhit-silkaijr Oct 28, 2025
0af8b98
removing unused
rhit-silkaijr Oct 28, 2025
c8360ae
removing revive
rhit-silkaijr Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
version: v1.55.2
version: v1.62.2
skip-pkg-cache: true
skip-build-cache: true

Expand Down
3 changes: 1 addition & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ linters-settings:
- github.com/satisfactorymodding/ficsit-cli/*

govet:
check-shadowing: true
check-shadowing: false
enable-all: true
disable:
- shadow
Expand Down Expand Up @@ -49,7 +49,6 @@ linters:
- durationcheck
- errorlint
- goimports
- revive
- misspell
- prealloc
- whitespace
Expand Down
Loading