Add tests to image #188
Merged
Add tests to image #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoxyFarhad
force-pushed
the
add-tests-to-image
branch
from
840591e to
2c757fd
Compare
RoxyFarhad
force-pushed
the
add-tests-to-image
branch
from
7169cc1 to
530db78
Compare
RoxyFarhad
force-pushed
the
add-tests-to-image
branch
from
c2ee756 to
a350f6c
Compare
RoxyFarhad
commented
Dec 8, 2025
RoxyFarhad
force-pushed
the
add-tests-to-image
branch
from
70b6ece to
19080e9
Compare
RoxyFarhad
force-pushed
the
add-tests-to-image
branch
from
19080e9 to
de0a529
Compare
smoreinis
reviewed
Dec 9, 2025
examples/tutorials/10_async/00_base/000_hello_acp/tests/test_agent.py
Outdated
Show resolved
Hide resolved
smoreinis
reviewed
Dec 9, 2025
examples/tutorials/10_async/10_temporal/010_agent_chat/project/workflow.py
Show resolved
Hide resolved
smoreinis
reviewed
Dec 9, 2025
examples/tutorials/10_async/10_temporal/060_open_ai_agents_sdk_hello_world/Dockerfile
Outdated
Show resolved
Hide resolved
smoreinis
reviewed
Dec 9, 2025
examples/tutorials/10_async/10_temporal/070_open_ai_agents_sdk_tools/Dockerfile
Outdated
Show resolved
Hide resolved
smoreinis
reviewed
Dec 9, 2025
examples/tutorials/10_async/10_temporal/080_open_ai_agents_sdk_human_in_the_loop/Dockerfile
Outdated
Show resolved
Hide resolved
smoreinis
approved these changes
Dec 9, 2025
Contributor
smoreinis
left a comment
smoreinis
left a comment
There was a problem hiding this comment.
looks good! just a couple nits / questions
Contributor
|
also, some lint issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our integration tests with the scale-agentex repo, we need to build images of the agents here, but also build those images with the test_utils folder in there.
In the scale-agentex workflow, we run the tests that are defined in the agent workflow in the container directly. This PR fixes the dockerfiles to include those test files but also fixes some of the tests based on real testing.