Skip to content

feat: add multiple env support #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RoxyFarhad wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add multiple env support #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f2e47c5
adding the multiple env mapping feature
RoxyFarhad Dec 18, 2025
5259f20
fixing errors
RoxyFarhad Dec 18, 2025
c15a86c
fixing this
RoxyFarhad Dec 18, 2025
6c7bf65
new one
RoxyFarhad Dec 18, 2025
be68303
small fix
RoxyFarhad Dec 18, 2025
7881ec2
fixing validation
RoxyFarhad Dec 18, 2025
42a0727
update the tests
RoxyFarhad Dec 18, 2025
0c3a8c2
fixing the linter
RoxyFarhad Dec 18, 2025
f7809d6
Merge branch 'main' into RF/support-multiple-envs
RoxyFarhad Dec 22, 2025
b8af1f0
removing the main yaml
RoxyFarhad Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop

This file was deleted.

117 changes: 44 additions & 73 deletions src/agentex/lib/cli/commands/agents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,26 +83,24 @@ def delete(
@agents.command()
def cleanup_workflows(
agent_name: str = typer.Argument(..., help="Name of the agent to cleanup workflows for"),
force: bool = typer.Option(False, help="Force cleanup using direct Temporal termination (bypasses development check)"),
force: bool = typer.Option(
False, help="Force cleanup using direct Temporal termination (bypasses development check)"
),
):
"""
Clean up all running workflows for an agent.

By default, uses graceful cancellation via agent RPC.
With --force, directly terminates workflows via Temporal client.
This is a convenience command that does the same thing as 'agentex tasks cleanup'.
"""
try:
console.print(f"[blue]Cleaning up workflows for agent '{agent_name}'...[/blue]")

cleanup_agent_workflows(
agent_name=agent_name,
force=force,
development_only=True
)


cleanup_agent_workflows(agent_name=agent_name, force=force, development_only=True)

console.print(f"[green]✓ Workflow cleanup completed for agent '{agent_name}'[/green]")

except Exception as e:
console.print(f"[red]Cleanup failed: {str(e)}[/red]")
logger.exception("Agent workflow cleanup failed")
Expand All @@ -112,12 +110,8 @@ def cleanup_workflows(
@agents.command()
def build(
manifest: str = typer.Option(..., help="Path to the manifest you want to use"),
registry: str | None = typer.Option(
None, help="Registry URL for pushing the built image"
),
repository_name: str | None = typer.Option(
None, help="Repository name to use for the built image"
),
registry: str | None = typer.Option(None, help="Registry URL for pushing the built image"),
repository_name: str | None = typer.Option(None, help="Repository name to use for the built image"),
platforms: str | None = typer.Option(
None, help="Platform to build the image for. Please enter a comma separated list of platforms."
),
Expand All @@ -126,9 +120,7 @@ def build(
None,
help="Docker build secret in the format 'id=secret-id,src=path-to-secret-file'",
),
tag: str | None = typer.Option(
None, help="Image tag to use (defaults to 'latest')"
),
tag: str | None = typer.Option(None, help="Image tag to use (defaults to 'latest')"),
build_arg: builtins.list[str] | None = typer.Option( # noqa: B008
None,
help="Docker build argument in the format 'KEY=VALUE' (can be used multiple times)",
Expand All @@ -143,7 +135,7 @@ def build(
if push and not registry:
typer.echo("Error: --registry is required when --push is enabled", err=True)
raise typer.Exit(1)

# Only proceed with build if we have a registry (for now, to match existing behavior)
if not registry:
typer.echo("No registry provided, skipping image build")
Expand Down Expand Up @@ -175,10 +167,7 @@ def build(
@agents.command()
def run(
manifest: str = typer.Option(..., help="Path to the manifest you want to use"),
cleanup_on_start: bool = typer.Option(
False,
help="Clean up existing workflows for this agent before starting"
),
cleanup_on_start: bool = typer.Option(False, help="Clean up existing workflows for this agent before starting"),
# Debug options
debug: bool = typer.Option(False, help="Enable debug mode for both worker and ACP (disables auto-reload)"),
debug_worker: bool = typer.Option(False, help="Enable debug mode for temporal worker only"),
Expand All @@ -190,26 +179,22 @@ def run(
Run an agent locally from the given manifest.
"""
typer.echo(f"Running agent from manifest: {manifest}")

# Optionally cleanup existing workflows before starting
if cleanup_on_start:
try:
# Parse manifest to get agent name
manifest_obj = AgentManifest.from_yaml(file_path=manifest)
agent_name = manifest_obj.agent.name

console.print(f"[yellow]Cleaning up existing workflows for agent '{agent_name}'...[/yellow]")
cleanup_agent_workflows(
agent_name=agent_name,
force=False,
development_only=True
)
cleanup_agent_workflows(agent_name=agent_name, force=False, development_only=True)
console.print("[green]✓ Pre-run cleanup completed[/green]")

except Exception as e:
console.print(f"[yellow]⚠ Pre-run cleanup failed: {str(e)}[/yellow]")
logger.warning(f"Pre-run cleanup failed: {e}")

# Create debug configuration based on CLI flags
debug_config = None
if debug or debug_worker or debug_acp:
Expand All @@ -224,19 +209,19 @@ def run(
mode = DebugMode.ACP
else:
mode = DebugMode.NONE

debug_config = DebugConfig(
enabled=True,
mode=mode,
port=debug_port,
wait_for_attach=wait_for_debugger,
auto_port=False # Use fixed port to match VS Code launch.json
auto_port=False, # Use fixed port to match VS Code launch.json
)

console.print(f"[blue]🐛 Debug mode enabled: {mode.value}[/blue]")
if wait_for_debugger:
console.print("[yellow]⏳ Processes will wait for debugger attachment[/yellow]")

try:
run_agent(manifest_path=manifest, debug_config=debug_config)
except Exception as e:
Expand All @@ -247,30 +232,23 @@ def run(

@agents.command()
def deploy(
cluster: str = typer.Option(
..., help="Target cluster name (must match kubectl context)"
),
cluster: str = typer.Option(..., help="Target cluster name (must match kubectl context)"),
manifest: str = typer.Option("manifest.yaml", help="Path to the manifest file"),
namespace: str | None = typer.Option(
None,
help="Override Kubernetes namespace (defaults to namespace from environments.yaml)",
),
environment: str | None = typer.Option(
None, help="Environment name (dev, prod, etc.) - must be defined in environments.yaml. If not provided, the namespace must be set explicitly."
),
tag: str | None = typer.Option(None, help="Override the image tag for deployment"),
repository: str | None = typer.Option(
None, help="Override the repository for deployment"
),
interactive: bool = typer.Option(
True, "--interactive/--no-interactive", help="Enable interactive prompts"
None,
help="Environment name (dev, prod, etc.) - must be defined in environments.yaml. If not provided, the namespace must be set explicitly.",
),
tag: str | None = typer.Option(None, help="Override the image tag for deployment"),
repository: str | None = typer.Option(None, help="Override the repository for deployment"),
interactive: bool = typer.Option(True, "--interactive/--no-interactive", help="Enable interactive prompts"),
):
"""Deploy an agent to a Kubernetes cluster using Helm"""

console.print(
Panel.fit("🚀 [bold blue]Deploy Agent[/bold blue]", border_style="blue")
)
console.print(Panel.fit("🚀 [bold blue]Deploy Agent[/bold blue]", border_style="blue"))

try:
# Validate manifest exists
Expand All @@ -281,17 +259,12 @@ def deploy(

# Validate manifest and environments configuration
try:
if environment:
_, environments_config = validate_manifest_and_environments(
str(manifest_path),
required_environment=environment
)
agent_env_config = environments_config.get_config_for_env(environment)
console.print(f"[green]✓[/green] Environment config validated: {environment}")
else:
agent_env_config = None
console.print(f"[yellow]⚠[/yellow] No environment provided, skipping environment-specific config")

_, environments_config = validate_manifest_and_environments(
str(manifest_path), required_environment=environment
)
agent_env_config = environments_config.get_config_for_env(environment)
console.print(f"[green]✓[/green] Environment config validated: {environment}")

except EnvironmentsValidationError as e:
error_msg = generate_helpful_error_message(e, "Environment validation failed")
console.print(f"[red]Configuration Error:[/red]\n{error_msg}")
Expand All @@ -310,9 +283,13 @@ def deploy(
console.print(f"[blue]ℹ[/blue] Using namespace from environments.yaml: {namespace_from_config}")
namespace = namespace_from_config
else:
raise DeploymentError(f"No namespace found in environments.yaml for environment: {environment}, and not passed in as --namespace")
raise DeploymentError(
f"No namespace found in environments.yaml for environment: {environment}, and not passed in as --namespace"
)
elif not namespace:
raise DeploymentError("No namespace provided, and not passed in as --namespace and no environment provided to read from an environments.yaml file")
raise DeploymentError(
"No namespace provided, and not passed in as --namespace and no environment provided to read from an environments.yaml file"
)

# Confirm deployment (only in interactive mode)
console.print("\n[bold]Deployment Summary:[/bold]")
Expand All @@ -325,9 +302,7 @@ def deploy(

if interactive:
proceed = questionary.confirm("Proceed with deployment?").ask()
proceed = handle_questionary_cancellation(
proceed, "deployment confirmation"
)
proceed = handle_questionary_cancellation(proceed, "deployment confirmation")

if not proceed:
console.print("Deployment cancelled")
Expand All @@ -337,9 +312,7 @@ def deploy(

check_and_switch_cluster_context(cluster)
if not validate_namespace(namespace, cluster):
console.print(
f"[red]Error:[/red] Namespace '{namespace}' does not exist in cluster '{cluster}'"
)
console.print(f"[red]Error:[/red] Namespace '{namespace}' does not exist in cluster '{cluster}'")
raise typer.Exit(1)

deploy_overrides = InputDeployOverrides(repository=repository, image_tag=tag)
Expand All @@ -356,9 +329,7 @@ def deploy(
# Use the already loaded manifest object
release_name = f"{manifest_obj.agent.name}-{cluster}"

console.print(
"\n[bold green]🎉 Deployment completed successfully![/bold green]"
)
console.print("\n[bold green]🎉 Deployment completed successfully![/bold green]")
console.print("\nTo check deployment status:")
console.print(f" kubectl get pods -n {namespace}")
console.print(f" helm status {release_name} -n {namespace}")
Expand Down
Loading