Fix test_list_trackers_with_order_by broken test #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kers task_repo.create() auto-creates an AgentTaskTracker for each task. The test was incorrectly creating additional trackers manually, resulting in 6 trackers instead of the expected 3. Removed manual tracker creation since the auto-created trackers are sufficient for testing order_by functionality.
Collaborator
Author
|
We only run unit tests in the checks here, but this is an integration test which I'm not sure gets exercised on commits. Thoughts on having this run on PRs also or elsewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
test_list_trackers_with_order_bywhich has been broken since it was introduced in #84.Problem
The test was creating trackers manually, not accounting for the fact that
task_repo.create()auto-creates anAgentTaskTrackerfor each task. This resulted in 6 trackers instead of the expected 3.Solution
Removed manual tracker creation — the auto-created trackers are sufficient for testing order_by functionality.
Test Plan
test_list_trackers_with_order_bynow passes