perf: Optimize single-result queries and add HTTP client cleanup #116
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace .scalars().all()[0] with .scalars().first() in 4 methods in agent_api_key_repository.py for more efficient single-result queries - Add HttpxGateway.close_clients() call to FastAPI lifespan shutdown for proper HTTP client cleanup on application shutdown - Remove TODO comment from close_clients() since it's now implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two quick performance/reliability fixes:
Issue #7: Inefficient single-result queries
.scalars().all()[0]with.scalars().first()in 4 methods inagent_api_key_repository.py[0].first()stops after fetching one rowMethods fixed:
get_internal_api_key_by_agent_idget_by_agent_id_and_nameget_by_agent_name_and_key_nameget_external_by_agent_id_and_keyIssue #8: HTTP client not closed on shutdown
HttpxGateway.close_clients()call to FastAPI lifespan shutdownTest plan