Skip to content

Conversation

@brokenjade3000
Copy link

#561

The current httpx doesn't support proxies arguments:
https://github.com/encode/httpx/blob/master/httpx/_client.py#L239

Fixes #Enter the associated issue number.

Description

Describe your addition briefly to help the reviewers understand your contribution.

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

@arunkannawadi
Copy link
Collaborator

Thank you for this patch that avoids the deprecated, and now removed keyword.

@arunkannawadi arunkannawadi merged commit 8a0e780 into scholarly-python-package:develop Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants