-
Notifications
You must be signed in to change notification settings - Fork 46
apurva and louise submitting interactiveprogramming #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… for the mid-project check-in
…led out yet though
…opefully will help us with general implementation and making buttons.
… using pandas, caught up to where we were before without pandas and figured out color settings.
… patience (or memory) to write individual commit messages for
|
@nielsenlouise + @apurvaraman - nice job on this and working with Bokeh - it's tough for sure. In terms of your writeup, it was well-organized, clear, and thoughtful. Good point about being more cautious when scoping out a project that uses a library you're unfamiliar with. Also, good note about using pandas as recommended by Bokeh, though I'm sure if searching through dictionaries would've been that big of a bottleneck since you can do direct lookups in dictionaries and not necessarily have to "iterate" through the dictionary (though you're right - you would have to go through all the separate category dictionaries). I'll add comments to your code after this. |
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| thing = View() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall - code looks good! It was nicely designed and well documented. For the most part, variable names were sensibly chosen.
You should include a .gitignore file in your repository to prevent *.pyc files from being pushed. For more info on .gitignore, see https://git-scm.com/docs/gitignore
This change is