Skip to content

Conversation

@apan64
Copy link

@apan64 apan64 commented Mar 10, 2016

This change is Reviewable

@jenwei
Copy link

jenwei commented Apr 4, 2016

@apan64 + @davpapp - awesome job on this difficult project. In terms of the report, it was well-organized, thorough, and thoughtful. This game had a lot of technical components, so congrats on getting it to work on that front.

I'll review your code shortly after this.

@jenwei
Copy link

jenwei commented Apr 4, 2016

Overall, good job on the code - nice job remembering to add docstrings with short descriptions. Would be nice to have more in-line comments are there are portions of your code that have a lot of similar lines, so adding a short comment describing what's happening would be beneficial.

Also, adding headers at the top of each file describing what it contains/what it does would help improve code readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants