Skip to content

Conversation

@Mikhaela
Copy link

No description provided.

@LucyWilcox
Copy link

Review status: 0 of 75 files reviewed at latest revision, 6 unresolved discussions.


The_Real_Deal/interaction.py, line 1 [r10] (raw file):
why is there a 'real deal' and not labeled version of this? why not just push the final one which ever it is?


The_Real_Deal/interaction.py, line 39 [r10] (raw file):
explain this numbers


The_Real_Deal/interaction.py, line 144 [r10] (raw file):
All these numbers.... explain them or set them to variables first.


The_Real_Deal/interaction.py, line 385 [r10] (raw file):
Yeah, maybe don't have everything in one big file. Generally though this is good except you have a lot of "magic numbers" which you need to explain or set to variables.


The_Real_Deal/Mini Project 4 Writeup.pdf, line 0 [r10] ([raw file](https://github.com/sd16spring/interactiveprogramming/blob/a6dc1973028c8467f6bd8f2d61c3b1d8782cd1f3/The_Real_Deal/Mini Project 4 Writeup.pdf#L0)):
I would have like to see a bit more covering what you did accomplish, and some discussion about design decisions. You had a really good reflection though.


The_Real_Deal/README.md, line 2 [r10] (raw file):
Putting a bit in here about what libraries you need to download and how to do so is always nice.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants