Skip to content

Conversation

@linnealaux
Copy link

This is not our real code!


This change is Reviewable

@linnealaux
Copy link
Author

This is our real code!

@kailevy
Copy link

kailevy commented Apr 3, 2016

Reviewed 53 of 53 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 10 unresolved discussions.


AK_SEEDLING.csv, line 0 [r2] (raw file):
Put these in a separate data folder for organization


heatmap.py, line 1 [r2] (raw file):
Remove this file if you don't use it (it looks unused)


InteractiveProgramming.pdf, line 0 [r2] (raw file):
I had a bit of trouble getting your code working because of dependencies as well as missing svg and csv files. Instructions on how to run your code should go in a README (you didn't update yours so I can't comment on it) so people can do so without confusion.


map.py, line 86 [r2] (raw file):
These constants can go at the top of the file


map.py, line 105 [r2] (raw file):
You do this several times, couldn't these variables be passed around as function arguments instead?


map.py, line 147 [r2] (raw file):
Put these in a main() function


map.py, line 151 [r2] (raw file):
Why here? Should be at the top


map.py, line 173 [r2] (raw file):
Try to avoid magic numbers like these


map.py, line 183 [r2] (raw file):
Seems like this stuff could go into a draw function as part of the view


map.py, line 197 [r2] (raw file):
This stuff could be part of a controller


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants