Skip to content

Conversation

@SungwooPark
Copy link

This change is Reviewable

@kailevy
Copy link

kailevy commented Apr 4, 2016

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions.


game_model.py, line 57 [r1] (raw file):
This control sequence could be simplified, simply select a type and map it to the filename instead of continuous if-elses


game_model.py, line 203 [r1] (raw file):
Brick breaker?


motherload.py, line 61 [r1] (raw file):
Very hairy.. any ways to simplify this? And collisions should be separate from view (mentioned in writeup)


motherload.py, line 108 [r1] (raw file):
Doing a lot of string comparisons may be slow, could store colors as ints instead


motherload.py, line 274 [r1] (raw file):
Really?


motherload.py, line 331 [r1] (raw file):
This stuff could go into a controller instead of main()


motherload.py, line 373 [r1] (raw file):
I encountered a bug trying to move left several times and being unable to


writeup.pdf, line 0 [r1] (raw file):
The bit about the expanding world is interesting, would like to see your solution implemented.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants