Skip to content

Conversation

@sammyers
Copy link

This change is Reviewable

sammyers and others added 28 commits March 2, 2016 20:48
@LucyWilcox
Copy link

Review status: 0 of 10 files reviewed at latest revision, 10 unresolved discussions.


controller.py, line 4 [r9] (raw file):
👍


game.py, line 6 [r9] (raw file):
Some comment on what this file does would be nice, even though you talk about it in your readme.


game.py, line 27 [r9] (raw file):
Get rid of comments like this before pushing your final


game.py, line 31 [r9] (raw file):
You should explain exactly what count is doing a bit better.


helpers.py, line 1 [r9] (raw file):
Very file should have at least some sort of comment, even if the name helpers is pretty self explanatory.


linkedlist.py, line 1 [r9] (raw file):
Did you write this code? It seems like a python linked-list implementation is something you would get from elsewhere, which is fine, but you need to cite it (you really really need to do this). If you wrote it, you should have more docstrings and comments.


model.py, line 30 [r9] (raw file):
Explain all these numbers (2, 6, 9, 50) that you are using.


model.py, line 41 [r9] (raw file):
What is this?


model.py, line 96 [r9] (raw file):
Get rid of this stuff before making your pull request!


view.py, line 6 [r9] (raw file):
👍


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants