Skip to content

Conversation

@rebeccagettys
Copy link

https://github.com/rebeccagettys/TextFiltering
The link above is my actual repo, I just forked this so I could submit via a pull request! thanks!

Review on Reviewable

https://github.com/rebeccagettys/TextFiltering
The link above is my actual repo, I just forked this so I could submit via a pull request!
@kailevy
Copy link

kailevy commented Mar 18, 2016

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.


text_filter.py, line 37 [r1] (raw file):
You can remove this stuff when submitting


text_filter.py, line 80 [r1] (raw file):
This can be done more concisely with a method described here


text_filter.py, line 135 [r1] (raw file):
This should be moved to main()


text_filter.py, line 142 [r1] (raw file):
These graph functions could definitely be combined into one function, with difference input arguments.


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants