Skip to content

Conversation

@Mikhaela
Copy link

Review on Reviewable

@kailevy
Copy link

kailevy commented Mar 18, 2016

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


nonet_generator.py, line 1 [r1] (raw file):
I would recommend cleaning up any unused files when you turn this in, it helps us figure out what to grade and is much cleaner


nonet_generator_actual.py, line 48 [r1] (raw file):
sentence_break


nonet_generator_actual.py, line 66 [r1] (raw file):
These are very specific stop and start conditions-- it would be more modular to take start and stop patterns as arguments for the function so that it could be adapted to other text.


nonet_generator_actual.py, line 77 [r1] (raw file):
This is pretty neat!


nonet_generator_actual.py, line 157 [r1] (raw file):
It would be a little cleaner to build up a single string (string += poem + '\n'), then write it as a a whole at the end (f.write(string + '\n\n\n'))


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants