Project Submission

[lzuehsow]

[jenwei]

Review status: 0 of 3 files reviewed at latest revision, 10 unresolved discussions.

---

getnews.py, line 2 [r1] (raw file):
Don't forget to purge your files of irrelevant comments/code.

Also, docstring here would be great with a short description of what the file contains/does.

---

getnews.py, line 30 [r1] (raw file):
Docstring here would be great to describe what's going on in this function.

---

getnews.py, line 33 [r1] (raw file):
To make your code more modular and reusable, you could have the URL be an inputted argument as opposed to a hard-coded variable.

---

getnews.py, line 76 [r1] (raw file):
Would be good to clean up unused, deprecated code or to add some comments explaining what the commented code does (is it still functional? what was it used for? etc.)

---

GetWiki.py, line 11 [r1] (raw file):
Nice definition of what's considered "significant".

---

GetWiki.py, line 18 [r1] (raw file):
Nice use of \ to improve readability.

In the future, it's common practice to name globals with variable names in "ALL CAPS".

---

GetWiki.py, line 68 [r1] (raw file):
To take this a step farther, you could put this (and the code below) into a wrapper function that takes in two arguments, language and title, as opposed to hard-coding them.

---

Reflection.txt, line 2 [r1] (raw file):
Nice, clear overview of the project. Awesome that you thought about common words cluttering the high-freq list.

---

Reflection.txt, line 13 [r1] (raw file):
Nice insights - and the one-liner to tie it all together is interesting. Would be nice to see more examples and analysis of your results.

---

Reflection.txt, line 37 [r1] (raw file):
Thoughtful and honest reflection. Good point about diving in and spending more time coding instead of researching. Though researching is still important, sometimes it's easiest and most effective to do a bit of research and then just go for it and look things up as you go.

---

Comments from the review on Reviewable.io

[jenwei]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

---

Comments from the review on Reviewable.io